Allow passing sensitive credentials for java_export with environment variables #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shs96c
reviewed
Jul 5, 2023
| Credentials credentials = new BasicAuthCredentials( | ||
| getArg(args, "MAVEN_USER", 2), | ||
| getArg(args, "MAVEN_PASSWORD", 3) | ||
| ); | ||
|
|
||
| List<String> parts = Arrays.asList(args[4].split(":")); |
There was a problem hiding this comment.
If the user isn't passing in the user or password on the command line, then the coordinates are likely to be at args position 2, right? Or is it okay because the script it quoting them, so we end up with empty values?
There was a problem hiding this comment.
Yes, the quoted strings in _TEMPLATE in maven_publish.bzl will ensure the arg positions are consistent even if empty.
thirtyseven
force-pushed
the
better-password
branch
from
e6981dd to
ca6539d
Compare
shs96c
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #679 by allowing users to specify
maven_userandmaven_passvia environment variable when usingmaven_publish.