feat(builtin): enable coverage on nodejs_test

BREAKING CHANGE: jasmine_node_test not longer has the `coverage`
attribute

internal/node/node.bzl

@@ -155,6 +155,14 @@ def _nodejs_binary_impl(ctx):
         if k in ctx.var.keys():
             env_vars += "export %s=\"%s\"\n" % (k, ctx.var[k])
 
+    # indicates that this was run with `bazel coverage`
+    # and that we should collect and store coverage
+    # TODO: store coverage in the location bazel tells us
+    if ctx.configuration.coverage_enabled:
+        # TODO: not sure if $RANDOM is the best var here
+        # but we need a new dir between runs
+        env_vars += "export NODE_V8_COVERAGE=$TEST_TMPDIR/$RANDOM\n"
+
     expected_exit_code = 0
     if hasattr(ctx.attr, "expected_exit_code"):
         expected_exit_code = ctx.attr.expected_exit_code

package.json

@@ -65,7 +65,6 @@
         "typeorm": "0.2.18",
         "typescript": "3.1.6",
         "unidiff": "1.0.1",
-        "v8-coverage": "1.0.9",
         "webpack": "~4.41.0",
         "zone.js": "0.8.29"
     },

packages/jasmine/src/index.from_src.bzl

@@ -19,7 +19,7 @@ load(":index.bzl", _jasmine_node_test = "jasmine_node_test")
 
 def jasmine_node_test(
         deps = [],
-        jasmine_deps = ["@npm//jasmine", "@npm//jasmine-core", "@npm//v8-coverage"],
+        jasmine_deps = ["@npm//jasmine", "@npm//jasmine-core"],
         **kwargs):
     _jasmine_node_test(
         # When there is no @npm//@bazel/jasmine package we use @npm_bazel_jasmine instead.

packages/jasmine/src/jasmine_node_test.bzl

@@ -74,11 +74,6 @@ def jasmine_node_test(
     templated_args = kwargs.pop("templated_args", [])
     templated_args.append("$(location :%s_devmode_srcs.MF)" % name)
 
-    if coverage:
-        templated_args.append("--coverage")
-    else:
-        templated_args.append("--nocoverage")
-
     if config_file:
         # Calculate a label relative to the user's BUILD file
         pkg = Label("%s//%s:__pkg__" % (native.repository_name(), native.package_name()))

packages/jasmine/src/jasmine_runner.js

@@ -1,5 +1,4 @@
 const fs = require('fs');
-const path = require('path');
 const bazelJasmine = require('@bazel/jasmine');
 
 const JasmineRunner = bazelJasmine.jasmine;
@@ -60,22 +59,16 @@ function readArg() {
 }
 
 function main(args) {
-  if (args.length < 3) {
+  if (args.length < 2) {
     throw new Error('expected argument missing');
   }
 
 
   // first args is always the path to the manifest
   const manifest = require.resolve(readArg());
-  // second is always a flag to enable coverage or not
-  const coverageArg = readArg();
-  const enableCoverage = coverageArg === '--coverage';
   // config file is the next arg
   const configFile = readArg();
 
-  // the relative directory the coverage reporter uses to find anf filter the files
-  const cwd = process.cwd();
-
   const jrunner = new JasmineRunner({jasmineCore: jasmineCore});
   if (configFile !== '--noconfig') {
     jrunner.loadConfigFile(require.resolve(configFile));
@@ -86,17 +79,6 @@ function main(args) {
                        // Filter out files from node_modules
                        .filter(f => !IS_NODE_MODULE.test(f))
 
-  const sourceFiles = allFiles
-                          // Filter out all .spec and .test files so we only report
-                          // coverage against the source files
-                          .filter(f => !IS_TEST_FILE.test(f))
-                          // the jasmine_runner.js gets in here as a file to run
-                          .filter(f => !f.endsWith('jasmine_runner.js'))
-                          .map(f => require.resolve(f))
-                          // the reporting lib resolves the relative path to our cwd instead of
-                          // using the absolute one so match it here
-                          .map(f => path.relative(cwd, f))
-
   allFiles
       // Filter here so that only files ending in `spec.js` and `test.js`
       // are added to jasmine as spec files. This is important as other
@@ -116,53 +98,11 @@ function main(args) {
   // so we need to add it back
   jrunner.configureDefaultReporter({});
 
-
-  let covExecutor;
-  let covDir;
-  if (enableCoverage) {
-    // lazily pull these deps in for only when we want to collect coverage
-    const crypto = require('crypto');
-    const Execute = require('v8-coverage/src/execute');
-
-    // make a tmpdir inside our tmpdir for just this run
-    covDir = path.join(process.env['TEST_TMPDIR'], String(crypto.randomBytes(4).readUInt32LE(0)));
-    covExecutor = new Execute({include: sourceFiles, exclude: []});
-    covExecutor.startProfiler();
-  }
-
   jrunner.onComplete((passed) => {
     let exitCode = passed ? 0 : BAZEL_EXIT_TESTS_FAILED;
     if (noSpecsFound) exitCode = BAZEL_EXIT_NO_TESTS_FOUND;
 
-    if (enableCoverage) {
-      const Report = require('v8-coverage/src/report');
-      covExecutor.stopProfiler((err, data) => {
-        if (err) {
-          console.error(err);
-          process.exit(1);
-        }
-        const sourceCoverge = covExecutor.filterResult(data.result);
-        // we could do this all in memory if we wanted
-        // just take a look at v8-coverage/src/report.js and reimplement some of those methods
-        // but we're going to have to write a file at some point for bazel coverage
-        // so may as well support it now
-        // the lib expects these paths to exist for some reason
-        fs.mkdirSync(covDir);
-        fs.mkdirSync(path.join(covDir, 'tmp'));
-        // only do a text summary for now
-        // once we know what format bazel coverage wants we can output
-        // lcov or some other format
-        const report = new Report(covDir, ['text-summary']);
-        report.store(sourceCoverge);
-        report.generateReport();
-
-        process.exit(exitCode);
-      });
-    } else {
-      process.exit(exitCode);
-    }
-
-
+    process.exit(exitCode);
   });
 
   if (TOTAL_SHARDS) {