Skip to content

Commit

Permalink
the nodejs_* macros should forward tags onto the sh_* target
Browse files Browse the repository at this point in the history
This makes it work with ibazel again
  • Loading branch information
alexeagle committed Nov 9, 2017
1 parent e283989 commit 31d36ff
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions internal/node.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ nodejs_test = rule(
)

# Wrap in an sh_binary for windows .exe wrapper.
def nodejs_binary_macro(name, args=[], visibility=None, **kwargs):
def nodejs_binary_macro(name, args=[], visibility=None, tags=[], **kwargs):
nodejs_binary(
name = "%s_bin" % name,
**kwargs
Expand All @@ -225,13 +225,14 @@ def nodejs_binary_macro(name, args=[], visibility=None, **kwargs):
native.sh_binary(
name = name,
args = args,
tags = tags,
srcs = [":%s_bin.sh" % name],
data = [":%s_bin" % name],
visibility = visibility,
)

# Wrap in an sh_test for windows .exe wrapper.
def nodejs_test_macro(name, args=[], visibility=None, **kwargs):
def nodejs_test_macro(name, args=[], visibility=None, tags=[], **kwargs):
nodejs_test(
name = "%s_bin" % name,
testonly = 1,
Expand All @@ -241,6 +242,7 @@ def nodejs_test_macro(name, args=[], visibility=None, **kwargs):
native.sh_test(
name = name,
args = args,
tags = tags,
visibility = visibility,
srcs = [":%s_bin.sh" % name],
data = [":%s_bin" % name],
Expand Down

0 comments on commit 31d36ff

Please sign in to comment.