Skip to content

Commit

Permalink
chore(builtin): remove every copy_to_bin rule previously added
Browse files Browse the repository at this point in the history
  • Loading branch information
mistic committed Aug 17, 2020
1 parent b2d789d commit 96d1543
Show file tree
Hide file tree
Showing 14 changed files with 21 additions and 97 deletions.
13 changes: 4 additions & 9 deletions packages/jasmine/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
load("@build_bazel_rules_nodejs//:index.bzl", "copy_to_bin", "nodejs_test")
load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_test")
load("@build_bazel_rules_nodejs//:tools/defaults.bzl", "pkg_npm")
load("@build_bazel_rules_nodejs//internal/js_library:js_library.bzl", "js_library")
load("@build_bazel_rules_nodejs//tools/stardoc:index.bzl", "stardoc")
Expand Down Expand Up @@ -53,20 +53,15 @@ nodejs_test(
],
)

copy_to_bin(
name = "srcs",
js_library(
name = "jasmine",
package_name = "@bazel/jasmine",
srcs = [
"index.js",
"jasmine_runner.js",
],
)

js_library(
name = "jasmine",
package_name = "@bazel/jasmine",
srcs = [":srcs"],
)

# Ugly genrule depending on local linux environment to build the README out of skylark doc generation.
# Only referenced when we do a release.
# TODO: This ought to be possible with stardoc alone. Need to coordinate with Chris Parsons.
Expand Down
2 changes: 1 addition & 1 deletion packages/jasmine/test/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("@build_bazel_rules_nodejs//:index.bzl", "copy_to_bin")
load("//:index.bzl", "copy_to_bin")
load("//packages/jasmine:index.bzl", "jasmine_node_test")
load("//packages/typescript:index.bzl", "ts_library")

Expand Down
8 changes: 1 addition & 7 deletions packages/rollup/test/integration/foo/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
load("@build_bazel_rules_nodejs//:index.bzl", "copy_to_bin")
load("@build_bazel_rules_nodejs//internal/js_library:js_library.bzl", "js_library")
load("//packages/typescript:index.bzl", "ts_project")
load("//third_party/github.com/bazelbuild/bazel-skylib:rules/copy_file.bzl", "copy_file")
Expand All @@ -19,17 +18,12 @@ ts_project(
deps = ["@npm//date-fns"],
)

copy_to_bin(
name = "user_d_ts",
srcs = ["user.d.ts"],
)

js_library(
name = "foo_lib",
package_name = "@foo/lib",
srcs = [
":index.js",
":user.js",
":user_d_ts",
"user.d.ts",
],
)
8 changes: 1 addition & 7 deletions packages/rollup/test/integration/fum/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,15 +1,9 @@
load("@build_bazel_rules_nodejs//:index.bzl", "copy_to_bin")
load("//internal/js_library:js_library.bzl", "js_library")

package(default_visibility = ["//packages/rollup:__subpackages__"])

copy_to_bin(
name = "index",
srcs = ["index.js"],
)

js_library(
name = "fumlib",
package_name = "fumlib",
srcs = [":index"],
srcs = ["index.js"],
)
10 changes: 2 additions & 8 deletions packages/typescript/test/ts_project/js_library/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,20 +1,14 @@
load("@build_bazel_rules_nodejs//:index.bzl", "copy_to_bin")
load("//internal/js_library:js_library.bzl", "js_library")
load("//packages/typescript:index.bzl", "ts_project")

copy_to_bin(
name = "srcs",
js_library(
name = "lib_a",
srcs = [
"a.d.ts",
"a.js",
],
)

js_library(
name = "lib_a",
srcs = [":srcs"],
)

ts_project(
name = "tsconfig",
srcs = ["b.ts"],
Expand Down
8 changes: 1 addition & 7 deletions scripts/vendor_npm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ rename() {
# $1 - license file
build_file_header() {
echo """# Generated by /scripts/vendor_npm.sh
load(\"@build_bazel_rules_nodejs//:index.bzl\", \"copy_to_bin\")
load(\"//internal/js_library:js_library.bzl\", \"js_library\")
package(default_visibility = [\"//visibility:public\"])
Expand All @@ -104,14 +103,9 @@ licenses([\"notice\"])
# Vendored on ${DATE} from npm with /scripts/vendor_npm.sh
exports_files([\"$1\"])
copy_to_bin(
name = \"srcs\",
srcs = glob([\"**/*.js\"]),
)
js_library(
name = \"$(basename ${PKG})\",
srcs = [\":srcs\"],
srcs = glob([\"**/*.js\"]),
package_name = \"${PKG}\",
)
""" > ${DST_DIR}/BUILD.bazel
Expand Down
13 changes: 4 additions & 9 deletions third_party/github.com/gjtorikian/isBinaryFile/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ licenses(["notice"])
exports_files(["LICENSE"])

load("@build_bazel_rules_nodejs//internal/js_library:js_library.bzl", "js_library")
load("@build_bazel_rules_nodejs//:index.bzl", "copy_to_bin")

# BEGIN-INTERNAL
load("//packages/typescript:index.bzl", "ts_project")
Expand All @@ -16,16 +15,12 @@ ts_project(
)
# END-INTERNAL

copy_to_bin(
name = "package_json_bin",
srcs = [
"package.json",
]
)

js_library(
name = "isBinaryFile",
srcs = [":package_json_bin", "src/index.js"],
srcs = [
"src/index.js",
"package.json",
],
package_name = "isbinaryfile",
visibility = ["//visibility:public"],
)
Expand Down
8 changes: 1 addition & 7 deletions third_party/npm/node_modules/@babel/core/BUILD.bazel

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 1 addition & 7 deletions third_party/npm/node_modules/babelify/BUILD.bazel

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 1 addition & 7 deletions third_party/npm/node_modules/base64-js/BUILD.bazel

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 1 addition & 7 deletions third_party/npm/node_modules/browserify/BUILD.bazel

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 1 addition & 7 deletions third_party/npm/node_modules/ieee754/BUILD.bazel

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 1 addition & 7 deletions third_party/npm/node_modules/named-amd/BUILD.bazel

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 96d1543

Please sign in to comment.