Skip to content

Commit

Permalink
build: disable examples_protobufjs on windows (#2596)
Browse files Browse the repository at this point in the history
  • Loading branch information
mattem authored Apr 8, 2021
1 parent c5ed4f8 commit d36b77c
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 9 deletions.
3 changes: 3 additions & 0 deletions examples/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,9 @@ example_integration_test(
"//packages/jasmine:npm_package": "@bazel/jasmine",
"//packages/typescript:npm_package": "@bazel/typescript",
},
# Flakes on windows
# TODO: understand flake fail mode and re-enable
tags = ["no-bazelci-windows"],
)

example_integration_test(
Expand Down
16 changes: 8 additions & 8 deletions packages/esbuild/esbuild.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,14 @@ See https://esbuild.github.io/api/#minify for more details
mandatory = False,
doc = "Name of the output file when bundling",
),
"output_css": attr.output(
mandatory = False,
doc = """Declare a .css file will be output next to output bundle.
If your JS code contains import statements that import .css files, esbuild will place the
content in a file next to the main output file, which you'll need to declare. If your output
file is named 'foo.js', you should set this to 'foo.css'.""",
),
"output_dir": attr.bool(
default = False,
doc = """If true, esbuild produces an output directory containing all the output files from code splitting
Expand All @@ -225,14 +233,6 @@ See https://esbuild.github.io/api/#splitting for more details
mandatory = False,
doc = "Name of the output source map when bundling",
),
"output_css": attr.output(
mandatory = False,
doc = """Declare a .css file will be output next to output bundle.
If your JS code contains import statements that import .css files, esbuild will place the
content in a file next to the main output file, which you'll need to declare. If your output
file is named 'foo.js', you should set this to 'foo.css'.""",
),
"platform": attr.string(
default = "browser",
values = ["node", "browser", "neutral", ""],
Expand Down
2 changes: 1 addition & 1 deletion packages/esbuild/test/css/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
load("@build_bazel_rules_nodejs//:index.bzl", "copy_to_bin")
load("//packages/esbuild/test:tests.bzl", "esbuild")
load("//packages/jasmine:index.bzl", "jasmine_node_test")
load("//packages/typescript:index.bzl", "ts_library")
load("@build_bazel_rules_nodejs//:index.bzl", "copy_to_bin")

copy_to_bin(
name = "external_copied",
Expand Down

0 comments on commit d36b77c

Please sign in to comment.