Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @yarn// back-compat workspace #1144

Closed
alexeagle opened this issue Sep 17, 2019 · 0 comments · Fixed by #1160
Closed

Remove @yarn// back-compat workspace #1144

alexeagle opened this issue Sep 17, 2019 · 0 comments · Fixed by #1160
Labels
cleanup Tech debt, resolving it improves our own velocity
Milestone
1.0

Comments

@alexeagle
Copy link
Collaborator

https://github.com/bazelbuild/rules_nodejs/blob/master/docs/Built-ins.md#node_repositories says

This rule also exposes the @Yarn workspace for backwards compatibility

we could drop that.
@alexeagle alexeagle added this to the 1.0 milestone Sep 17, 2019
@alexeagle alexeagle added the cleanup Tech debt, resolving it improves our own velocity label Sep 17, 2019
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Sep 20, 2019
@alexeagle
chore: cleanup some deprecated APIs
876efe6 
BREAKING CHANGE:
@bazel/typescript and @bazel/karma no longer have a defs.bzl file. Use
index.bzl instead.

The @Yarn workspace is no longer created. Use @nodejs//:yarn instead.

Fixes bazel-contrib#1144
@alexeagle alexeagle mentioned this issue Sep 20, 2019
Merged
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Sep 20, 2019
@alexeagle
chore: cleanup some deprecated APIs
003a8ba 
BREAKING CHANGE:
@bazel/typescript and @bazel/karma no longer have a defs.bzl file. Use
index.bzl instead.

The @Yarn workspace is no longer created. Use @nodejs//:yarn instead.

Fixes bazel-contrib#1144
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Sep 20, 2019
@alexeagle
chore: cleanup some deprecated APIs
ae2f128 
BREAKING CHANGE:
@bazel/typescript and @bazel/karma no longer have a defs.bzl file. Use
index.bzl instead.

The @Yarn workspace is no longer created. Use @nodejs//:yarn instead.

Fixes bazel-contrib#1144
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Sep 20, 2019
@alexeagle
chore: cleanup some deprecated APIs
c663e98 
BREAKING CHANGE:
@bazel/typescript and @bazel/karma no longer have a defs.bzl file. Use
index.bzl instead.

The @Yarn workspace is no longer created. Use @nodejs//:yarn instead.

Fixes bazel-contrib#1144
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Sep 21, 2019
@alexeagle
chore: cleanup some deprecated APIs
6076e07 
BREAKING CHANGE:
@bazel/typescript and @bazel/karma no longer have a defs.bzl file. Use
index.bzl instead.

The @Yarn workspace is no longer created. Use @nodejs//:yarn instead.

Fixes bazel-contrib#1144
gregmagolan pushed a commit that referenced this issue Sep 21, 2019
@alexeagle @gregmagolan
chore: cleanup some deprecated APIs (#1160)
cefc2ae 
BREAKING CHANGE:
@bazel/typescript and @bazel/karma no longer have a defs.bzl file. Use
index.bzl instead.

The @Yarn workspace is no longer created. Use @nodejs//:yarn instead.

Fixes #1144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Tech debt, resolving it improves our own velocity
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

chore: cleanup some deprecated APIs alexeagle/rules_nodejs
1 participant
@alexeagle