Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for stamping is incorrect #156

Closed
mmorearty opened this issue Mar 14, 2018 · 1 comment · Fixed by #162
Closed

Documentation for stamping is incorrect #156

mmorearty opened this issue Mar 14, 2018 · 1 comment · Fixed by #162
Labels
bug

Comments

@mmorearty
Copy link
Contributor

In the readme, the explanation of how to do stamping is wrong. Basically, if you are writing a genrule that has stamp = True, that genrule will only work as expected if it has at least one file in its srcs. See bazelbuild/bazel#4842 for a full explanation.
@alexeagle
Copy link
Collaborator

Ooh, thanks for finding that Mike. Silently stamping with an old value is a nasty bug!

@alexeagle alexeagle added the bug label Mar 19, 2018
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Mar 23, 2018
@alexeagle
Use ctx.version_file in place of a genrule with stamp=True
ae42769 
Fixes bazel-contrib#156
@alexeagle alexeagle mentioned this issue Mar 23, 2018
Merged
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Mar 23, 2018
@alexeagle
Use ctx.version_file in place of a genrule with stamp=True
21f2274 
Fixes bazel-contrib#156
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Mar 23, 2018
@alexeagle
Use ctx.version_file in place of a genrule with stamp=True
d830d7c 
Fixes bazel-contrib#156
alexeagle added a commit that referenced this issue Mar 23, 2018
@alexeagle
Use ctx.version_file in place of a genrule with stamp=True (#162)
6ac160f 
Fixes #156
alexeagle added a commit to alexeagle/angular that referenced this issue Mar 23, 2018
@alexeagle
build: fix bazel stamping
04a3e9e 
As pointed out in bazel-contrib/rules_nodejs#156 our mechanism would never pick up changes to the version info.
@alexeagle alexeagle mentioned this issue Mar 23, 2018
Closed
alexeagle added a commit to alexeagle/angular that referenced this issue Mar 23, 2018
@alexeagle
build: fix bazel stamping
fdaeed8 
As pointed out in bazel-contrib/rules_nodejs#156
our mechanism would never pick up changes to the version info.
alexeagle added a commit to alexeagle/angular that referenced this issue Mar 28, 2018
@alexeagle
build: fix bazel stamping
4201251 
As pointed out in bazel-contrib/rules_nodejs#156
our mechanism would never pick up changes to the version info.
alxhub pushed a commit to angular/angular that referenced this issue Mar 28, 2018
@alexeagle @alxhub
build: fix bazel stamping (#22965)
0b348c8 
As pointed out in bazel-contrib/rules_nodejs#156
our mechanism would never pick up changes to the version info.

PR Close #22965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ctx.version_file in place of a genrule with stamp=True alexeagle/rules_nodejs
2 participants
@alexeagle @mmorearty