Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove dynamic_deps feature #1276

Merged
merged 1 commit into from
Oct 23, 2019

Commits on Oct 22, 2019

  1. refactor: remove dynamic_deps feature

    This isn't the right way to declare that a rule depends on a plugin.
    
    - It is too hard for users to understand what this means, how to
    configure it correctly, and to discover that their broken tool needs a
    dynamic dep.
    - It is not npm-idiomatic. The dependency graph at install time is not
    meant to reflect the actual dependencies that will be loaded at runtime.
    
    In the rollup example, the `rollup.config.js` has `import
    'rollup-plugin-json'`
    so the corresponding BUILD file should have that package in the deps.
    
    BREAKING CHANGE:
    
    The dynamic_deps attribute of yarn_install and npm_install is removed,
    in favor of declaring needed packages in the deps/data of the rule that
    invokes the tool.
    alexeagle committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    2bf735b View commit details
    Browse the repository at this point in the history