fix(builtin): set cwd before running yarn for yarn_install #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix the same for @nodejs//:yarn & @nodejs//:yarn_node_repositories targets.
This allows yarn to pickup the `yarn-path` attribute of `.yarnrc` which is only checked inside `${process.cwd()}/.yarnrc` when yarn runs. Previously we running yarn with `--cwd` which works for all other `.yarnrc` options except `yarn-path`.
josephperrott
added a commit
to josephperrott/angular
that referenced
this pull request
Jan 22, 2020
Rather than enforcing yarn versioning using `package.json`'s engines value. We can utilize yarn's `yarn-path` value to ensure that the version of yarn used at execution time is consistent for everyone who uses our repo. This is the first step in this wider vendoring process. We will use this same vendoring mechanism for CI after bazel-contrib/rules_nodejs#1569 lands
josephperrott
added a commit
to josephperrott/angular
that referenced
this pull request
Jan 22, 2020
Rather than enforcing yarn versioning using `package.json`'s engines value. We can utilize yarn's `yarn-path` value to ensure that the version of yarn used at execution time is consistent for everyone who uses our repo. This is the first step in this wider vendoring process. We will use this same vendoring mechanism for CI after bazel-contrib/rules_nodejs#1569 lands
josephperrott
added a commit
to josephperrott/angular
that referenced
this pull request
Jan 22, 2020
Rather than enforcing yarn versioning using `package.json`'s engines value. We can utilize yarn's `yarn-path` value to ensure that the version of yarn used at execution time is consistent for everyone who uses our repo. This is the first step in this wider vendoring process. We will use this same vendoring mechanism for CI after bazel-contrib/rules_nodejs#1569 lands
alexeagle
approved these changes
Jan 22, 2020
AndrewKushnir
pushed a commit
to angular/angular
that referenced
this pull request
Jan 23, 2020
Rather than enforcing yarn versioning using `package.json`'s engines value. We can utilize yarn's `yarn-path` value to ensure that the version of yarn used at execution time is consistent for everyone who uses our repo. This is the first step in this wider vendoring process. We will use this same vendoring mechanism for CI after bazel-contrib/rules_nodejs#1569 lands PR Close #34902
AndrewKushnir
pushed a commit
to angular/angular
that referenced
this pull request
Jan 23, 2020
Rather than enforcing yarn versioning using `package.json`'s engines value. We can utilize yarn's `yarn-path` value to ensure that the version of yarn used at execution time is consistent for everyone who uses our repo. This is the first step in this wider vendoring process. We will use this same vendoring mechanism for CI after bazel-contrib/rules_nodejs#1569 lands PR Close #34902
josephperrott
added a commit
to josephperrott/components
that referenced
this pull request
Jan 27, 2020
Rather than enforcing yarn versioning using `package.json`'s engines value. We can utilize yarn's `yarn-path` value to ensure that the version of yarn used at execution time is consistent for everyone who uses our repo. This is the first step in this wider vendoring process. We will use this same vendoring mechanism for CI after bazel-contrib/rules_nodejs#1569 lands
sonukapoor
pushed a commit
to sonukapoor/angular
that referenced
this pull request
Feb 13, 2020
Rather than enforcing yarn versioning using `package.json`'s engines value. We can utilize yarn's `yarn-path` value to ensure that the version of yarn used at execution time is consistent for everyone who uses our repo. This is the first step in this wider vendoring process. We will use this same vendoring mechanism for CI after bazel-contrib/rules_nodejs#1569 lands PR Close angular#34902
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also do the same for @nodejs//:yarn & @nodejs//:yarn_node_repositories targets.
This allows yarn to pickup the
yarn-pathattribute of.yarnrcwhich is only checked inside${process.cwd()}/.yarnrcwhen yarn runs. Previously we ran yarn with--cwdwhich works for all other.yarnrcoptions exceptyarn-path.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information