chore(examples): upgrade rules_nodejs and angular #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Jason! I should have mentioned that the ViewEngine example needs to say at Angular 8 for this PR (just the @angular/bazel package should get updated to 9.0.0 there). Should dig further into that error at some point however there are some issues with Bazel + ViewEngine (like the AMD patch needed & the necessary ngc postinstall) so I'd recommend that anyone updating to v9 with Bazel use Ivy anyway. |
gregmagolan
requested review from
alexeagle,
gregmagolan and
soldair
as code owners
gregmagolan
approved these changes
Feb 11, 2020
jbedard
commented
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.