Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builtin): always symlink node_modules at execroot/my_wksp/node_modules even when running in runfiles #1805

Merged
merged 1 commit into from
Apr 9, 2020

Commits on Apr 9, 2020

  1. fix(builtin): always symlink node_modules at `execroot/my_wksp/node_m…

    …odules` even when running in runfiles
    
    Under runfiles, the linker should symlink node_modules at `execroot/my_wksp` so that when there are no runfiles (default on Windows) and scripts run out of `execroot/my_wksp` they can resolve node_modules with standard node_module resolution
    
    Also, restore BAZEL_WORKSPACE name environment variable. The optimization of deriving the workspace name from the path does not work on RBE. While we can derive the workspace from the pwd when running locally because it is in the execroot path `execroot/my_wksp`, on RBE the `execroot/my_wksp` path is reduced a path such as `/w/f/b` so the workspace name is obfuscated from the path. So we provide the workspace name here as an environment variable avaiable to all actions for the runfiles helpers to use.
    gregmagolan committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    f399be3 View commit details
    Browse the repository at this point in the history