test(builtin): add test for issue 1813 #1814
Merged
+1,933
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
issue_1813
branch
2 times, most recently
from
d0e03c7
to
41ba541
Compare
gregmagolan
force-pushed
the
issue_1813
branch
6 times, most recently
from
f2099da
to
c997c99
Compare
Issue bazel-contrib#1813 was fixed by bazel-contrib#1800 which is already landed. bazel-contrib#1805 also fixes via a different mechanism and will also land soon.
alexeagle
approved these changes
Apr 9, 2020
| "--no-cache", | ||
| "--no-watchman", | ||
| "--ci", | ||
| # On Windows, spawing workers is broken |
There was a problem hiding this comment.
oh! I wish I could use this to land the always-link-bins PR too
| # On Windows, spawing workers is broken | ||
| "--runInBand", | ||
| "--config", | ||
| "$$(rlocation $(rootpath jest.config.js))", |
There was a problem hiding this comment.
random note: any time we write this under the /examples directory we should comment about it
There was a problem hiding this comment.
It would be rad if this were args=[".dist/bin/jest.config.js"]) and we fixed it up later in the toolchain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1813 was fixed by #1800 which is already landed. #1805 also fixes via a different mechanism and will also land soon.