feat(cypress): add cypress_web_test rule and @bazel/cypress package #1930
Conversation
mrmeku
force-pushed
the
cypress
branch
9 times, most recently
from
c78ee84
to
a8784b2
Compare
mrmeku
force-pushed
the
cypress
branch
16 times, most recently
from
0d05d8c
to
eed4a00
Compare
mrmeku
force-pushed
the
cypress
branch
3 times, most recently
from
28fa367
to
c2287c7
Compare
mrmeku
changed the title
|
@alexeagle @gregmagolan time for a review! :D |
| ], | ||
| ) | ||
|
|
||
| ts_library( |
There was a problem hiding this comment.
any particular reason you chose ts_library rather than ts_project? I expect most users will prefer the latter since it's compatible with their existing code
There was a problem hiding this comment.
The reason I opted for ts_library was to test that I consumed the ts_library providers correctly. Maybe I should use both a ts_library and ts_project? What do you think?
There was a problem hiding this comment.
we shouldn't have a difference between providers, such that you can tell whether ts_project or ts_library was used to compile your dependency. Could you file an issue with the details about what's different? I hope you don't still need the "typescript" provider
| @@ -0,0 +1,6 @@ | |||
| describe('world', () => { | |||
There was a problem hiding this comment.
why is there a .ts and .js file both checked in? I suspect this one doesn't belong
There was a problem hiding this comment.
I did so to show how to load a .js file as a test and as a .ts file as a test respectively
mrmeku
force-pushed
the
cypress
branch
6 times, most recently
from
308f9de
to
c5f806b
Compare
mrmeku
force-pushed
the
cypress
branch
7 times, most recently
from
7381a43
to
4872e4d
Compare
| ], | ||
| ) | ||
|
|
||
| ts_library( |
There was a problem hiding this comment.
we shouldn't have a difference between providers, such that you can tell whether ts_project or ts_library was used to compile your dependency. Could you file an issue with the details about what's different? I hope you don't still need the "typescript" provider
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Add @bazel/cypress for integrating cypress testing framework with bazel
Left todo:
Show how to launch a nodejs_binary server from cypress plugin