Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fetch node toolchain based on exec platform, not target platform #2565

Closed
wants to merge 1 commit into from
Closed

fix: fetch node toolchain based on exec platform, not target platform #2565

wants to merge 1 commit into from

Commits on Mar 28, 2021

  1. fix: fetch node toolchain based on exec platform, not target platform 

    Currently rules_nodejs can't be used when cross-compiling to a different
platform, if that platform does not have a node toolchain available.
This means if you want to cross-compile a project that includes JS
files, you need to do it in multiple steps:

- build the JS files with the default host platform
- build the other products with a target platform specified, copying
the generated JS files in

The fact that it's currently set to target makes me wonder if this
use case was just not considered at the time, or whether there's some
other workflow that changing to exec will break. Thoughts?
    @dae
    dae committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    bccbad9 View commit details
    Browse the repository at this point in the history