feat(esbuild): allow ts / tsx files in esbuilds srcs #2594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattem
force-pushed
the
feat/esbuild-ts-srcs
branch
from
9636182
to
91616f6
Compare
|
|
alexeagle
approved these changes
Apr 8, 2021
packages/esbuild/esbuild.bzl
Outdated
| doc = """Non-entry point JavaScript source files from the workspace. | ||
|
|
||
| You must not repeat file(s) passed to entry_point""", | ||
| doc = """Source files to be made avialble to esbuild""", |
mattem
force-pushed
the
feat/esbuild-ts-srcs
branch
from
91616f6
to
9162eb6
Compare
|
Need to add an extra test in here. I think I've broken the case where if you have only JS sources in |
mattem
force-pushed
the
feat/esbuild-ts-srcs
branch
from
9162eb6
to
f0801d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Esbuild can take
.tsfiles as an input and compile to js, this change allows that, and shows that you can plumb together bothesbuild,ts_projectandjs_libraryin novel ways to compile Typescript and bundle it.It's a little tricky to handle the
entry_point, as we resolve a.tsentrypoint to its js for the user. This change means that if a.tsfile is passed toentry_pointthen it's expected to be insrcs, rather thandeps.As a breaking change in 4.0.0, I'd like to propose that we don't automagically resolve to a
.jsinput, and the user has to specify the correct extension, or at least provide a flag to flip to the new behaviour, or back to thelegacy_resolve_ts_entry_points(I like verbose names).closes #2594