refactor(builtin): npm_umd_bundle no longer allows directory sources #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We plan to change behavior under exports_directories_only so that they produce TreeArtifacts. They will therefore be a subfolder of the real package. npm_umd_bundle is too hard to keep working with exports_directories_only because it relies on loading npm packages without the linker. BREAKING CHANGE: npm_umd_bundle users cannot use exports_directories_only
alexeagle
requested review from
gregmagolan,
mattem and
soldair
as code owners
It no longer works since npm_umd_bundle can't work with exports_directories_only. Note: we have other examples that provide integration test coverage for exports_directories_only
gregmagolan
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan to change behavior under exports_directories_only so that they produce TreeArtifacts. They will therefore be a subfolder of the real package.
npm_umd_bundle is too hard to keep working with exports_directories_only because it relies on loading npm packages without the linker.
BREAKING CHANGE:
npm_umd_bundle users cannot use exports_directories_only