Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bbrnj re-exports rules_nodejs providers #3274

Merged
merged 1 commit into from
Jan 23, 2022
Merged

Conversation

alexeagle
Copy link
Collaborator

This makes the 5.0 release less breaking by restoring back-compat with
rulesets that loaded these from the old location.

I manually verified that the same symbol comes through, so even though
a provider creation and usage site load from different places, the
provided symbol still matches and works.

This makes the 5.0 release less breaking by restoring back-compat with
rulesets that loaded these from the old location.

I manually verified that the same symbol comes through, so even though
a provider creation and usage site load from different places, the
provided symbol still matches and works.
Copy link
Collaborator

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@alexeagle alexeagle merged commit a9d8644 into stable Jan 23, 2022
@alexeagle alexeagle deleted the reexport branch January 23, 2022 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants