Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builtin): pass kwargs from node_repositories helper #3287

Merged
merged 1 commit into from
Jan 26, 2022
Merged

fix(builtin): pass kwargs from node_repositories helper #3287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions e2e/nodejs_host/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ nodejs_test(
"@nodejs_host//:npm_bin",
"@nodejs_host//:npm_files",
"@nodejs_host//:npx_bin",
"@npm//:node_modules",
"@yarn",
"@yarn//:yarn_bin",
"@yarn//:yarn_files",
Expand Down
6 changes: 5 additions & 1 deletion e2e/nodejs_host/WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@ load("@build_bazel_rules_nodejs//:repositories.bzl", "build_bazel_rules_nodejs_d

build_bazel_rules_nodejs_dependencies()

load("@build_bazel_rules_nodejs//:index.bzl", "yarn_install")
load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories", "yarn_install")

node_repositories(
node_version = "12.12.0",
)

yarn_install(
name = "npm",
Expand Down
1 change: 1 addition & 0 deletions e2e/nodejs_host/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"dependencies": {},
"scripts": {
"postinstall": "node -e \"require('assert').equal(process.version, 'v12.12.0')\"",
"test": "bazel test ..."
}
}
2 changes: 1 addition & 1 deletion internal/node/node_repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ def node_repositories(**kwargs):
)

# Install new toolchain under "nodejs" repository name prefix
nodejs_register_toolchains(name = "nodejs")
nodejs_register_toolchains(name = "nodejs", **kwargs)