feat: add npm binary & files to toolchain provider #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
opt_in_npm_in_toolchain
branch
from
3e2713c to
ca0e82d
Compare
gregmagolan
added a commit
to gregmagolan/rules_nodejs
that referenced
this pull request
Oct 6, 2022
alexeagle
pushed a commit
that referenced
this pull request
Oct 6, 2022
gregmagolan
force-pushed
the
opt_in_npm_in_toolchain
branch
from
ca0e82d to
c2e4f80
Compare
alexeagle
reviewed
Oct 6, 2022
nodejs/toolchain.bzl
Outdated
| @@ -89,6 +105,19 @@ node_toolchain = rule( | |||
| doc = "Path to an existing nodejs executable for the target platform.", | |||
| mandatory = False, | |||
| ), | |||
| "npm": attr.label( | |||
| doc = "A hermetically downloaded npm executable target for the target platform.", | |||
There was a problem hiding this comment.
nit: should these really say for the "target platform"?
There was a problem hiding this comment.
right, the node fields are target_tool and target_tool_path.
target_npm, target_npm_path and target_npm_files?
There was a problem hiding this comment.
no I think the fields are named fine, it's just the docstring that's a tad misleading (for node as well - it was an existing problem here)
alexeagle
approved these changes
Oct 6, 2022
gregmagolan
force-pushed
the
opt_in_npm_in_toolchain
branch
from
c2e4f80 to
ef88576
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream rules that use the toolchain can choose to include the npm binary & files specified by the toolchain as inputs for actions.