fix: allow root repositories to override node toolchain version under bzlmod #3626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kormide
requested review from
mattem,
gregmagolan and
alexeagle
as code owners
kormide
force-pushed
the
bzlmod-toolchain
branch
from
8584240 to
51ebbf3
Compare
kormide
changed the title
alexeagle
reviewed
Feb 23, 2023
kormide
force-pushed
the
bzlmod-toolchain
branch
from
51ebbf3 to
642ae5e
Compare
alexeagle
reviewed
Feb 23, 2023
kormide
force-pushed
the
bzlmod-toolchain
branch
from
642ae5e to
fb5d0f8
Compare
kormide
commented
Feb 23, 2023
aherrmann
reviewed
Feb 24, 2023
kormide
force-pushed
the
bzlmod-toolchain
branch
2 times, most recently
from
718528a to
c809f44
Compare
alexeagle
approved these changes
Feb 24, 2023
kormide
force-pushed
the
bzlmod-toolchain
branch
from
c809f44 to
9a5b97f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses aspect-build/rules_js#864.