Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable and green up e2e/smoke and e2e/nodejs_host tests on GitHub Actions #3752

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented Jun 6, 2024

The coverage on Bazel CI doesn't cover all cases. This is a pre-factor for fixing the #3720 bug.

@gregmagolan gregmagolan force-pushed the fix_bzlmod_nodejs_host branch 5 times, most recently from 584e2d4 to 2be9a79 Compare June 6, 2024 23:03
@gregmagolan gregmagolan force-pushed the fix_bzlmod_nodejs_host branch from 2be9a79 to 48786e9 Compare June 6, 2024 23:05
@gregmagolan gregmagolan changed the title fix: fix nodejs_repo_host_os_alias repo with bzlmod chore: enable and green up e2e/smoke and e2e/nodejs_host tests on GitHub Actions Jun 6, 2024
@gregmagolan gregmagolan marked this pull request as ready for review June 6, 2024 23:12
@gregmagolan gregmagolan merged commit 08dde37 into main Jun 6, 2024
16 checks passed
@gregmagolan gregmagolan deleted the fix_bzlmod_nodejs_host branch June 6, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants