Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: in rules_js MODULE.bazel use default value for name of node.toolchain() #3759

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented Jun 8, 2024

No reason to set an explicit name here since it always has to be DEFAULT_NODE_REPOSITORY or else the following line in extensions.bzl will fail downstream:

            if toolchain.name != DEFAULT_NODE_REPOSITORY and not mod.is_root:
                fail("Only the root module may provide a name for the node toolchain.")

@gregmagolan gregmagolan enabled auto-merge (squash) June 8, 2024 06:29
@gregmagolan gregmagolan merged commit 86d7acd into main Jun 8, 2024
15 checks passed
@gregmagolan gregmagolan deleted the use_default_name_in_root_module branch June 8, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants