Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runfiles): @bazel/runfiles usage with non-bzlmod repos #3794

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

jbedard
Copy link
Collaborator

@jbedard jbedard commented Oct 11, 2024

When in non-bzlmod and no _repo_mapping file exists the logic repo mapping logic should have no side-effects and should take the same code path as before 21b56da

@jbedard
Copy link
Collaborator Author

jbedard commented Oct 11, 2024

There still seem to be issues and differences with non-bzlmod in bazel 6 vs 7.

In bazel 7 the _repo_mapping seems to exist with non-bzlmod, but the mappings are essentially no-ops. While in bazel 6 the _repo_mapping does not exist at all. I can't get bazel 6 or 7 working properly with non-bzlmod in the rules_js e2e/runfiles tests.

But I believe @jfirebaugh reports this fix is working so I think it is good to land for now...

@jbedard jbedard merged commit 68b9bd6 into bazel-contrib:main Oct 11, 2024
16 checks passed
@jbedard jbedard deleted the runfiles-non-bzlmod branch October 11, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants