Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove use of incompatible_use_toolchain_transition #3812

Conversation

EdSchouten
Copy link
Contributor

As documented at https://bazel.build/rules/lib/globals/bzl.html#rule:

incompatible_use_toolchain_transition
bool; default is False
Deprecated, this is no longer in use and should be removed.

According to bazelbuild/bazel#14049, this feature was enabled by default back in 2021.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

rule() is called with incompatible_use_toolchain_transition = True. This argument is a no-op right now, because Bazel merely provides a placeholder for this option. However, having this argument in place would cause breakages if the Bazel team decides to remove this option altogether.

What is the new behavior?

We call it without this argument. This does not cause any noticeable differences.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

As documented at https://bazel.build/rules/lib/globals/bzl.html#rule:

    incompatible_use_toolchain_transition
    bool; default is False
    Deprecated, this is no longer in use and should be removed.

According to bazelbuild/bazel#14049, this
feature was enabled by default back in 2021.
@jbedard jbedard changed the title Stop using incompatible_use_toolchain_transition fix: remove use of incompatible_use_toolchain_transition Jan 16, 2025
@jbedard jbedard merged commit 1fc6b6b into bazel-contrib:main Jan 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants