-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Label in nodejs_binary#entry_point #480
feat: add support for Label in nodejs_binary#entry_point #480
Conversation
Please ignore the failing tests. This PR is in WIP. |
@alexeagle you mentioned that we shouldn't actually use the |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed. ℹ️ Googlers: Go here for more info. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed. ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Status updates (with #691 applied locally): |
Replaced by #777 |
… when node version is 10.2.0 or greater (bazel-contrib#480)
Also updates rollup_bundle entry_point and parcel example entry_point to labels
Also updates rollup_bundle entry_point and parcel example entry_point to labels
Also updates rollup_bundle entry_point and parcel example entry_point to labels
Also updates rollup_bundle entry_point and parcel example entry_point to labels
Also updates rollup_bundle entry_point and parcel example entry_point to labels
Also updates rollup_bundle entry_point and parcel example entry_point to labels
Also updates rollup_bundle entry_point and parcel example entry_point to labels
…le entry_point change (bazel-contrib#480) Also updates parcel example entry_point to label
…le entry_point change (#480) Also updates parcel example entry_point to label
Closes bazel-contrib#480 PiperOrigin-RevId: 288497658
Closes bazel-contrib#480 PiperOrigin-RevId: 288497658
Closes #32
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
nodejs_binary#entry_point was a string.
What is the new behavior?
nodejs_binary#entry_point is now a Label.
Does this PR introduce a breaking change?
The
entry_point
accepts a target's name as an entry point. If the target is a rule, it should produce the JavaScript entry file that will be passed to the nodejs_binary rule). For example:If the entry JavaScript file belongs to the same package (as the BUILD file), you can simply reference it by its relative name to the package directory: