Fix @bazel/jasmine jasmineCore re-export so that jasmine-core transitive dep of jasmine transitive-dep is always used #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference the case is. |
kyliau
reviewed
Apr 15, 2019
| const jasmineCore = require('jasmine-core'); | ||
| const path = require('path'); | ||
|
|
||
| // We want the jasmine-core version that is a transitive dependency of jasmine, however, |
There was a problem hiding this comment.
I'm thinking, if we need jasmine-core here, should it be part of the dependencies of this package so we don't have to guess where it gets installed?
There was a problem hiding this comment.
Ahhh.. Yes. That would be a much cleaner solution. @bazel/jasmine would have a dependency on the same version of jasmine-core that its jasmine dep does. Good call 😄
…ive dep of jasmine transitive-dep is always used
gregmagolan
force-pushed
the
fix-jasmine-core-require
branch
from
e8b1c79 to
565886f
Compare
|
Replaced by #698. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into yet another corner case for re-exporting the correct
jasmine-corefrom@bazel/jasminenpm package here: angular/angular#29913. I think I've thought it through fully now and this will always get the right version ofjasmine-core