-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oci_pull: handle OCI-format images #74
Comments
we should also add a test that our output matches e.g |
* Adding a helper script for Bzlmod migration. The script does the following things: - 1. Run the build without Bzlmod enabled to generate resolved external dependencies with --experimental_repository_resolved_file - 2. Run the build with Bzlmod enabled and identify recongnized error message - 3. Use the resolved external deps info to give migration suggestions. - 4. Repeat 2 and 3 until all external deps are available via Bzlmod (or WORKSPACE.bzlmod). To start the migration, clone the Bazel central registry repo and run the following command from your project root: ``` <path to a local BCR repo>/tools/migrate_to_bzlmod.py <build flags> <build targets> ``` * More fixes * Rename function * Address comments
Does google/go-containerregistry#1586 having merged (addressing google/go-containerregistry#1579) help advance this pursuit? Do we need a release there in order to make use of the new crane registry serve subcommand? |
We'll be cutting a new release for go-containerregistry and rules_oci this week. that'll fix this issue. |
That’s great news. Overcoming this gap leaves only bazelbuild/bazel@dfdf63a arriving in a Bazel release to get me back to where I once was with rules_docker. Oh, one more: @alexeagle’s stamping-related changes in #70. |
Leaving this open, as the new handling of images with a crane toolchain doesn't work under bzlmod:
->
|
We should be able to pull an image that's published in OCI format, for example
crane manifest quay.io/buildah/stable
Also it means we should handle more Media Types:
The text was updated successfully, but these errors were encountered: