Make LLD work with clang18 #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang has custom code to inject the
-platform_versionflag when invokinglld. This takes effect when we pass-fuse-ld=lld, which we currently don't do forlldbecause want to point at the hermetic one. Switch to using--ld-pathinstead, which is supported since Clang12.The current structure relies on
sanitize_optiongenerating 1 option per input, so I had to add the extra option check in the loop around it.This is why LLD didn't work for me when we first added this support.
Kudos to @keith for the analysis above :)
I think we should follow-up soon and make LLD the default; that should allow a lot of simplification