feat: Introduce pickTarget and pickPackage command variables
#354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogelsgesang
requested review from
coeuvre,
jfirebaugh and
cameron-martin
as code owners
|
@cameron-martin @jfirebaugh do you have time to review this? In case you currently don't have time to review in detail, I would appreciate high-level feedback whether you consider this functionality as valuable in general 🙂 |
|
I've been on holiday but I reckon I'll be able to take a look next week. The functionality does look useful though. |
vogelsgesang
force-pushed
the
avogelsgesang-command-var-quickpick
branch
2 times, most recently
from
d1c9a56 to
7cbb8b5
Compare
|
By the way: I think long-term it would make sense to also add support for |
cameron-martin
changed the title
pickTarget and pickPackage command variablespickTarget and pickPackage command variables
cameron-martin
requested changes
Apr 2, 2024
This commit introduces the `bazel.pickTarget` and `bazel.pickPackage`
command variables. Those commands can be used from `tasks.json` and
`launch.json` to prompt the user to select a Bazel target or package.
The available choices are determined by a user-specified Bazel query.
The implementation reuses the existing quick-pick functionality from
`bazel_quickpick.ts`. The `wrapQuickPick` function parses the arguments
passed from the `task.json` and then forwards to the existing quickpicks.
Those utility functions were restructured as part of this commit:
1. The internal helpers `queryWorkspaceQuickPickPackages` and
`queryWorkspaceQuickPickTargets` were inlined into
`queryQuickPick{Packages,Targets}` as the internal helper functions
got in the way of other changes, but didn't deduplicate any code as
they only had one caller.
2. The `queryQuickPick{Packages,Targets}` take an object with named
parameters now.
3. `queryQuickPickPackage` now also accepts a `query` parameter instead
of using the `queryExpression`. Both `queryQuickPickPackages` and
`queryQuickPickTargets` default to the query `//...` if no query
string is provided by the caller.
Point (3) also is a user-facing change. Commands like "Build package" and
"Test package" now use `//...` instead of the configured `queryExpression`.
This is in sync with other commands like "Test target" which uses the
hardcoded query `kind('.*_test rule', ...)`.
vogelsgesang
force-pushed
the
avogelsgesang-command-var-quickpick
branch
from
7cbb8b5 to
1fc4fc4
Compare
cameron-martin
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the
bazel.pickTargetandbazel.pickPackagecommand variables. Those commands can be used fromtasks.jsonandlaunch.jsonto prompt the user to select a Bazel target or package. The available choices are determined by a user-specified Bazel query.The implementation reuses the existing quick-pick functionality from
bazel_quickpick.ts. ThewrapQuickPickfunction parses the arguments passed from thetask.jsonand then forwards to the existing quickpicks.Those utility functions were restructured as part of this commit:
queryWorkspaceQuickPickPackagesandqueryWorkspaceQuickPickTargetswere inlined intoqueryQuickPick{Packages,Targets}as the internal helper functions got in the way of other changes, but didn't deduplicate any code as they only had one caller.queryQuickPick{Packages,Targets}take an object with named parameters now.queryQuickPickPackagenow also accepts aqueryparameter instead of using thequeryExpression. BothqueryQuickPickPackagesandqueryQuickPickTargetsdefault to the query//...if no query string is provided by the caller.Point (3) also is a user-facing change. Commands like "Build package" and "Test package" now use
//...instead of the configuredqueryExpression. This is in sync with other commands like "Test target" which uses the hardcoded querykind('.*_test rule', ...).