Revert "Avoid calling to_list in _get_cc_info_linker_inputs for perfo…

…rmance (#930) (#932)

This reverts commit 77c4afa.

We're seeing some behavior changes in tests caused by this change. I
haven't figured out the underlying issue yet, but I'm reverting this
change until we can figure it out.

rules/framework.bzl

@@ -562,9 +562,10 @@ def _get_cc_info_linker_inputs(*, deps):
         if not CcInfo in dep:
             continue
 
-        linker_inputs.append(dep[CcInfo].linking_context.linker_inputs)
+        for linker_input in dep[CcInfo].linking_context.linker_inputs.to_list():
+            linker_inputs.append(linker_input)
 
-    return depset([], transitive = linker_inputs)
+    return depset(linker_inputs)
 
 def _create_swiftmodule(attrs):
     kwargs = {}