Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings for a missing base class and pointer mismatch #763

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

jszumski
Copy link
Collaborator

@jszumski jszumski commented Sep 6, 2023

Fixes warnings for a missing base case:

tests/macos/xcodeproj/NonArcObject.h:1:12: warning: class 'NonArcObject' defined without specifying a base class [-Wobjc-root-class]
@interface NonArcObject
           ^
tests/macos/xcodeproj/NonArcObject.h:1:24: note: add a super class to fix this problem
@interface NonArcObject

and a pointer mismatch:

tools/xctest_absolute_source_locations/xctest_absolute_source_locations.m:39:44: warning: incompatible pointer types passing 'NSString *' to parameter of type 'NSURL *' [-Wincompatible-pointer-types]
    NSURL *workspaceURL = getWorkspacePath(testBundlePath);
                                           ^~~~~~~~~~~~~~
tools/xctest_absolute_source_locations/xctest_absolute_source_locations.m:14:39: note: passing argument to parameter 'testBundle' here
static NSURL *getWorkspacePath(NSURL *testBundle)

@mattrobmattrob mattrobmattrob enabled auto-merge (squash) September 6, 2023 18:12
@mattrobmattrob mattrobmattrob merged commit 35c7197 into master Sep 6, 2023
@mattrobmattrob mattrobmattrob deleted the jszumski/fix-warnings branch September 6, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants