Add CI tests for latest rules_swift and rules_apple #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
force-pushed
the
luis/add-tests-for-latest-rules_swift-latest-rules_apple
branch
from
773b11c
to
baf7d3c
Compare
gyfelton
approved these changes
Aug 21, 2024
| @@ -24,9 +24,13 @@ jobs: | |||
| xcode_version: [15.2] | |||
| virtual_frameworks: [true, false] | |||
| sandbox: [true, false] | |||
| latest_rules: [true, false] | |||
There was a problem hiding this comment.
you can consider adding exclude here for the known not working combo so that we don't even bother running it until we fixed the underlying issue
There was a problem hiding this comment.
I want to run it so that any future PRs can ensure thats green if they intended to fix the issue. I just wont mark it required in github so it wont block merges, thoughts?
There was a problem hiding this comment.
Yeah, that sounds reasonable. Looks like the latest rules don't work with bazel 6.5
There was a problem hiding this comment.
They also dont work in bazel 7 with vfs turned off
congt
approved these changes
Aug 21, 2024
jszumski
approved these changes
Aug 21, 2024
luispadron
force-pushed
the
luis/add-tests-for-latest-rules_swift-latest-rules_apple
branch
from
baf7d3c
to
417206f
Compare
luispadron
deleted the
luis/add-tests-for-latest-rules_swift-latest-rules_apple
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds another matrix for testing the latest rules_apple and rules_swift without having to update our
MODULE.bazel/WORKSPACE.bazelfiles.NOTE: the latest rules dont work fully yet so im expecting these jobs to fail. I'll leave the latest jobs as not required and mark the rest required until we fix support for the latest rules.