Remove swift info provider creation inside hmap rule #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyfelton
changed the title
gyfelton
changed the title
luispadron
reviewed
Sep 18, 2024
| module_map = None, | ||
| ), | ||
| )], | ||
| ) | ||
| providers = [ | ||
| DefaultInfo( | ||
| files = depset([headermap]), | ||
| ), | ||
| apple_common.new_objc_provider(), |
There was a problem hiding this comment.
We should try to remove this as well
There was a problem hiding this comment.
my understanding is bazel 6 still need it. but i can be wrong.
I feel that demands a separate PR to just remove all apple_common.Objc references? Also helps when have test against bazel "7.4" / nightly as the API apple_common.Objc is just gone now: https://bazel.build/rules/lib/toplevel/apple_common
thiagohmcruz
approved these changes
Sep 18, 2024
luispadron
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last place that touched this code is on https://github.com/bazel-ios/rules_ios/pull/906where I thought it's important to construct SwiftInfo provider for hmap and add compilation context to pass the failing test.
However that leads to a new issue with
docc_archiverule with latestrules_apple/rules_swift. We realized it's actually not needed to provide any SwiftInfo provider at all or it will "confuse" rules_swift/apple (since newer version starts to rely more on clang info from Swift info itself insteadapple_common.Objc). Removing this also have the original failing test passing.Tests done:
Will squash before merge as it contains already merged commits