Relanding of Add swift.experimental_rules_swift_package_manager flag back to master branch
#922
Conversation
gyfelton
changed the title
Add swift.experimental_rules_swift_package_manager flag back to master branch
Co-authored-by: Jonathan Schear <jonathanschear@gmail.com>
gyfelton
force-pushed
the
thiago/rules_swift_package_manager-1
branch
from
72ba0cf
to
d704f72
Compare
| if enable_rules_swift_package_manager and SwiftInfo in dep: | ||
| if dep.label.workspace_name.startswith("swiftpkg"): | ||
| for spm_dep in dep[SwiftInfo].transitive_modules.to_list(): |
There was a problem hiding this comment.
I dont really understand why we need to specifically check for rules_spm here, can you help me understand?
rules_spm creates swift_library_group targets which have deps attr, and all the things in deps should already have SwiftInfo so couldn't you just iterate through the deps here?
There was a problem hiding this comment.
We had other internal targets going through this conditional internally, the intent was to explicitly filter for only the SPM ones to minimize the chances of unintentionally breaking things for other consumers due to this being WIP-code under an experimental flag for now.
That said, if there's a more optimal way to collect the same info def open to suggestions.
There was a problem hiding this comment.
I guess I just don't understand what this is doing and why we should do it for rules_spm stuff but not rules_swift
There was a problem hiding this comment.
Not trying to block, feel free to merge if this fixes something for y'all. Trying to understand because we also use rules_spm and haven't needed this
already approved at #917
Now it's about landing it in master and since it is guarded by a flag, it's no op unless you enable this feature