Add initial visionOS support #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
requested review from
BalestraPatrick,
brentleyjones,
segiddins,
thii and
mattrobmattrob
as code owners
keith
force-pushed
the
ks/add-initial-visionos-support
branch
from
fa7fb2a to
3c70f29
Compare
Base automatically changed from
ks/add-stripped-down-apple_verification_test
to
master
July 11, 2023 21:46
mattrobmattrob
approved these changes
Jul 12, 2023
keith
force-pushed
the
ks/add-initial-visionos-support
branch
from
d894fc5 to
a56e41f
Compare
keith
force-pushed
the
ks/add-initial-visionos-support
branch
from
a56e41f to
e922bd5
Compare
Does that mean when we merge this that we drop support for anything before Bazel 7? (Though I think we can conditionalize our code to work around that.) |
|
Well if you backport that to 6.x maybe we'd only have to worry about 5.x (assuming it's reasonable to only support the newest 6.x). otherwise I do think we could conditionalize the setup that uses the platforms somehow which i think would be all we'd have to do |
keith
force-pushed
the
ks/add-initial-visionos-support
branch
from
e47c706 to
e32820e
Compare
keith
force-pushed
the
ks/add-initial-visionos-support
branch
from
e32820e to
bbf416f
Compare
brentleyjones
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on bazelbuild/bazel#18905 and bazelbuild/platforms#71