-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding VulkanSceneGraph v1.1.7 library to BCR #3118
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (vsg) have been updated in this PR. Please review the changes. |
Can you make the version |
@bazel-io skip_check unstable_url |
…ation issues on mac and android
…cstring to avoid linter warnings
Require module maintainers' approval for newly pushed changes.
…version is not available yet on build agents (cache?)
Dear BCR team, thank you for your help! Now I need to add one more module - vulkan 1.1 headers - this is the only required dependency for VSG 1.1.7. locally I have it installed globally, but on build agents its of course not installed. need to setup hermetic local environment at some point to have better experience working on BCR modules :) |
@artem-korolev There were already some WORKSPACE approaches for Vulkan e.g. https://github.com/zaucy/rules_vulkan - since you need also the SDK |
@Vertexwahn thank you. good point. Will try to apply it. Also found a platform specific dependency. On Linux it is XCB (#include <xcb/xcb.h>). Need to find out how to deal with that as well |
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (vsg) have been updated in this PR. Please review the changes. |
…an (update integrity)
Hi. Im a bit stuck here. Im trying to integrate rules_vulkan. But it does not build on build machines. I limited it to build only on ubuntu 24.04, to have more/less system like I have. I think i got here into some conceptual problem. I was trying to do everything with MODULE.bazel (extending it with *.bzl extensions), but it did not fly (i do something wrong and I cannot find example solving same issue). So not I understand that problem on build machine is that it does not support WORKSPACE files. I read docs, that WORKSPACE will be deprecated in bazel 8.x. But it still works in 7.x (which I can confirm building in locally). And found this issue - bazelbuild/bazel#18958, where its said, that bazel will fallback to use WORKSPACE. but maybe I misread something. So my question is, can I still use WORKSPACE? If not, then what will be easier and more convenient: refactor rules_vulkan, or integrate it to MODULE.bazel with newer api? In workspace its using http_archive (which i found how to use in MODULE.bazel), but then it runs some python functions (setup_7zip and vulkan_repo) - this I already do not understand how to reproduce in MODULE.bazel And problem is that on build machine it does not find "vulkan_sdk" repo. So repo is not registered. |
|
Hi @Vertexwahn, thank you for such a quick answer! I got my answer I needed and ideas. Can continue experimenting now. |
Hi,
I am quite new to Bazel BCR. Want to add VSG as a module. Already build it successfully locally with BUILD file provided in this PR.
It probably missing all scenarios that VSG support in their Cmake project. And I tested it with Linux system (Ubuntu 24.04) only.
But our team actively working on a game engine, so all platforms will be supported in feature (macos, linux, windows, android). So for now I put there a version "1.1.7.bcr.1", meaning that it is a first draft version, that I want to test out.