Skip to content

Commit

Permalink
Make only root test_deps externally visible (#508)
Browse files Browse the repository at this point in the history
All other test_deps targets implicitly require the root BUILD file
for the `license` target for their default_applicable_licenses;
therefore, users should only depend on the root test_deps target.
  • Loading branch information
tetromino authored Jul 15, 2024
1 parent da7ba2d commit 43c6185
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions lib/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ filegroup(
name = "test_deps",
testonly = True,
srcs = ["BUILD"] + glob(["*.bzl"]),
visibility = ["//:__subpackages__"], # Needs skylib's root BUILD file for default_applicable_licenses
)

# The files needed for distribution
Expand Down
1 change: 1 addition & 0 deletions rules/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ filegroup(
srcs = [
"BUILD",
] + glob(["*.bzl"]),
visibility = ["//:__subpackages__"], # Needs skylib's root BUILD file for default_applicable_licenses
)

# The files needed for distribution
Expand Down
2 changes: 1 addition & 1 deletion toolchains/unittest/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ filegroup(
srcs = [
"BUILD",
],
visibility = ["//:__subpackages__"],
visibility = ["//:__subpackages__"], # Needs skylib's root BUILD file for default_applicable_licenses
)

# The files needed for distribution
Expand Down

0 comments on commit 43c6185

Please sign in to comment.