Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag --incompatible_config_setting_private_default_visibility will break Bazel skylib in Bazel 7.0 #414

Closed
keertk opened this issue Nov 23, 2022 · 5 comments · Fixed by #452
Closed

Flag --incompatible_config_setting_private_default_visibility will break Bazel skylib in Bazel 7.0 #414

keertk opened this issue Nov 23, 2022 · 5 comments · Fixed by #452
Assignees
@tetromino
Labels
P2 We'll consider to work on this in future. (Assignee optional) type: bug

Comments

@keertk
Copy link
Member

keertk commented Nov 23, 2022 •
edited
Loading

Incompatible flag --incompatible_config_setting_private_default_visibility will be enabled by default in the next major release (Bazel 7.0), thus breaking Bazel skylib. Please migrate to fix this and unblock the flip of this flag.

The flag is documented here: bazelbuild/bazel#12933.

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything.
If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.
@keertk keertk mentioned this issue Nov 23, 2022
Open
@keertk keertk changed the title Flag --incompatible_config_setting_private_default_visibility will break Bazel skylib in a future Bazel release Flag --incompatible_config_setting_private_default_visibility will break Bazel skylib in Bazel 7.0 Nov 29, 2022
@sgowroji
Copy link
Member

Hi @bazel-skylib Team, Could you please look in to this issue.Thanks!

@tetromino
Copy link
Collaborator

The error is coming from an old rules_pkg dep - we need to bump it to 0.8 or newer.

@tetromino tetromino added type: bug P2 We'll consider to work on this in future. (Assignee optional) labels Jun 27, 2023
@tetromino tetromino self-assigned this Jun 27, 2023
tetromino added a commit to tetromino/bazel-skylib that referenced this issue Jun 27, 2023
@tetromino
Bump rules_pkg dep to 0.9.1 to fix build with --incompatible_config_s…
ed51a80 
…etting_private_default_visibility

Required for Bazel 7 compatibility.

Fixes bazelbuild#414
@tetromino tetromino mentioned this issue Jun 27, 2023
Merged
@tetromino
Copy link
Collaborator

Looks like the latest rules_pkg fails with Bazel at HEAD. Need to investigate :/

@aiuto
Copy link
Contributor

aiuto commented Jun 27, 2023 via email

@tetromino
Copy link
Collaborator

@aiuto - see https://buildkite.com/bazel/bazel-skylib/builds/2725

I suspect something about python toolchains changed in Bazel at HEAD

tetromino added a commit that referenced this issue Aug 8, 2023
@tetromino
Bump rules_pkg dep to 0.9.1 to fix build with --incompatible_config_s…
6fcbad3 
…etting_private_default_visibility (#452)

Required for Bazel 7 compatibility.

Note that rules_pkg 0.9.1 requires Python 3.6 or newer as the system's Python 3; this means we cannot build //distribution on Ubuntu 16.04 any more (which is fine, since it only affects the skylib developer workflow; users of skylib on Ubuntu 16.04 are not affected). Update CI config accordingly.

Fixes #414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tetromino tetromino

Labels
P2 We'll consider to work on this in future. (Assignee optional) type: bug
Projects
None yet
Milestone
No milestone
4 participants
@tetromino @aiuto @sgowroji @keertk