-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address lint errors #254
Address lint errors #254
Conversation
260b7f0
to
7aff8c1
Compare
@laurentlb it looks like it is not possible to fix all the linter errors in the repo. See bazelbuild/buildtools#865 for a more complete explanation of this. Can you advise on how to proceed? |
rules/common_settings.bzl
Outdated
@@ -12,6 +12,8 @@ | |||
# See the License for the specific language governing permissions and | |||
# limitations under the License. | |||
|
|||
# buildifier: disable=skylark-docstring | |||
# buildifier: disable=skylark-comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These comments are not required anymore, the latest version of buildifer shouldn't warn about the usage of this url anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
I see just one warning in the CI, it should disappear if you rerun the tests (the CI automatically uses the latest version of buildifier released). Also the disabling comments aren't required anymore. |
Looks like that fixed it. Thanks for addressing the linter issues @vladmos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
No description provided.