Allow unit test rules to be documented #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tetromino Friendly ping 😅 |
|
@tetromino One more friendly ping 😄 It'd be nice to have this in the next release |
tetromino
approved these changes
Feb 10, 2022
|
On second thought - we made a mistake here. New parameter should go to the end of the list, otherwise we break users who use |
tetromino
pushed a commit
that referenced
this pull request
Feb 10, 2022
ngiloq6
added a commit
to ngiloq6/bazel-skylib
that referenced
this pull request
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it more ergonomic to add notes or a description about a test to a
docattribute, similar to other rules, vs a comment block above it or in theimplfunction docstring. Hopefully this can improve the readability of test rules.