-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gazelle plugin to CI and distribution mechanism #424
Commits on Jan 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9da1db7 - Browse repository at this point
Copy the full SHA 9da1db7View commit details -
Update comments to keep all version numbers in sync
We now have 3 versions: the tarball version (version.bzl), the skylib module version (MODULE.bazel), and the gazelle plugin module version (gazelle/MODULE.bazel)
Configuration menu - View commit details
-
Copy full SHA for 739fa6e - Browse repository at this point
Copy the full SHA 739fa6eView commit details -
Add a distro tarball target for gazelle plugin and a //distribution f…
…ilegroup for all tarballs
Configuration menu - View commit details
-
Copy full SHA for 27651f8 - Browse repository at this point
Copy the full SHA 27651f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65fee77 - Browse repository at this point
Copy the full SHA 65fee77View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbebec3 - Browse repository at this point
Copy the full SHA cbebec3View commit details -
Configuration menu - View commit details
-
Copy full SHA for be0963b - Browse repository at this point
Copy the full SHA be0963bView commit details
Commits on Jan 19, 2023
-
Load gazelle plugin module from local subdir in bzlmod mode
Needed to allow building/testing gazelle plugin from bazelci and generating release tarballs when in bzlmod mode. Note that the local_path_override will be stripped out in the tarball release, so users of stable skylib releases will not be affected. Users of a live/unreleased version of skylib who depend on it via git_override will need to add a patch to remove or comment out the local_path_override. I expect the number of such users to be tiny, but I have added a comment in MODULE.bazel to guide them.
Configuration menu - View commit details
-
Copy full SHA for 0a2ff54 - Browse repository at this point
Copy the full SHA 0a2ff54View commit details -
Update rules_pkg to fix paths in gazelle plugin tarball
Needed to cleanly strip ./external/bazel_skylib_gazelle_plugin~* dir prefixes in the tarball. Also allows us to clean up fixed target name vs. versioned tarball file name without needing aliases. Note that we are using 0.7.0 since 0.8.0 is not yet in BCR.
Configuration menu - View commit details
-
Copy full SHA for 23799a2 - Browse repository at this point
Copy the full SHA 23799a2View commit details -
Make disabling local_path_override easier
Provide a patch file that users can use in their git_override
Configuration menu - View commit details
-
Copy full SHA for 42521ee - Browse repository at this point
Copy the full SHA 42521eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 953cc04 - Browse repository at this point
Copy the full SHA 953cc04View commit details