Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gazelle plugin to CI and distribution mechanism #424

Merged
merged 10 commits into from
Jan 20, 2023

Commits on Jan 17, 2023

  1. Configuration menu
    Copy the full SHA
    9da1db7 View commit details
    Browse the repository at this point in the history
  2. Update comments to keep all version numbers in sync

    We now have 3 versions: the tarball version (version.bzl), the skylib
    module version (MODULE.bazel), and the gazelle plugin module version
    (gazelle/MODULE.bazel)
    tetromino committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    739fa6e View commit details
    Browse the repository at this point in the history
  3. Add a distro tarball target for gazelle plugin and a //distribution f…

    …ilegroup for all tarballs
    tetromino committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    27651f8 View commit details
    Browse the repository at this point in the history
  4. Update release instructions

    tetromino committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    65fee77 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cbebec3 View commit details
    Browse the repository at this point in the history
  6. buildifier fixes

    tetromino committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    be0963b View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Load gazelle plugin module from local subdir in bzlmod mode

    Needed to allow building/testing gazelle plugin from bazelci and
    generating release tarballs when in bzlmod mode.
    
    Note that the local_path_override will be stripped out in the
    tarball release, so users of stable skylib releases will not be
    affected.
    
    Users of a live/unreleased version of skylib who depend on it via
    git_override will need to add a patch to remove or comment out
    the local_path_override. I expect the number of such users to be
    tiny, but I have added a comment in MODULE.bazel to guide them.
    tetromino committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    0a2ff54 View commit details
    Browse the repository at this point in the history
  2. Update rules_pkg to fix paths in gazelle plugin tarball

    Needed to cleanly strip ./external/bazel_skylib_gazelle_plugin~* dir
    prefixes in the tarball.
    
    Also allows us to clean up fixed target name vs. versioned tarball
    file name without needing aliases.
    
    Note that we are using 0.7.0 since 0.8.0 is not yet in BCR.
    tetromino committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    23799a2 View commit details
    Browse the repository at this point in the history
  3. Make disabling local_path_override easier

    Provide a patch file that users can use in their git_override
    tetromino committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    42521ee View commit details
    Browse the repository at this point in the history
  4. run buildifier

    tetromino committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    953cc04 View commit details
    Browse the repository at this point in the history