Skip to content
This repository has been archived by the owner on Sep 8, 2023. It is now read-only.

Add new EngFlow logo and update descriptions #325

Merged
merged 3 commits into from
Sep 28, 2021

Conversation

saraadams
Copy link
Contributor

Before and after screenshots:

Bazel Community Experts:
bazel-experts

Remote Execution Services:
bazel-re

@google-cla
Copy link

google-cla bot commented Sep 22, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 22, 2021
@hicksjoseph
Copy link

This line seems too subjective for this page: "EngFlow helps everyone get more value from Bazel by upstreaming changes in the interest of customers, and by connecting them to experts in the Bazel ecosystem.".

Perhaps it can be re-worded or excluded.

@saraadams
Copy link
Contributor Author

I've updated it to read
"EngFlow upstreams Bazel changes in the interest of customers, and connects them to experts in the Bazel ecosystem."

@saraadams
Copy link
Contributor Author

saraadams commented Sep 23, 2021

Thanks. I don't understand this phrase, "and by connecting them to experts in the Bazel ecosystem".

We have partnerships with other Bazel experts, who may help our customers on specific topics, e.g. migrating to Bazel.

By the way, do you have a few examples of this: "EngFlow upstreams Bazel changes in the interest of customers"?

Yes, of course! You can see recent commits by EngFlow here:

https://github.com/bazelbuild/bazel/commits?author=benjaminp
https://github.com/bazelbuild/bazel/commits?author=Yannic
https://github.com/bazelbuild/bazel/commits?author=ulfjack
https://github.com/bazelbuild/bazel/commits?author=laszlocsomor

There's also some open PRs, e.g.
bazelbuild/bazel#12719
bazelbuild/bazel#12112

Also, how does page "https://www.engflow.com/product/bazelForYou" relate to the text surrounding it?

It gives more information on how we help customers make Bazel work even better for them.
https://www.engflow.com/product/bazelForYou#openSourceContributions lists some Bazel contributions and current projects for our customers. C&P:
"We are actively working on multiple Bazel improvements, including: remote persistent workers, Java coverage, Kotlin rules, and C++ Include scanning.
We also co-maintain bazelbuild/rules_proto."

@hicksjoseph
Copy link

hicksjoseph commented Sep 23, 2021 via email

@saraadams
Copy link
Contributor Author

Here are a couple of examples:

bazelbuild/bazel@0a75645
While this change was done for one specific customer (cannot share the name), it has been used by other customers, and users in the community since.

bazelbuild/bazel#12719
bazelbuild/bazel#13778
These changes were done for Blue River Technology.

bazelbuild/bazel#13808
This change fixed a bug that surfaced for one of our customers.

@hicksjoseph
Copy link

Hi. You might want to change your blurb to say something like "and has partnerships with other Bazel Experts" or something similar. Let me know when you have made any changes and I will take a look.

@saraadams
Copy link
Contributor Author

We discussed and prefer the current wording.

@hicksjoseph
Copy link

I am sorry that I can't approve the change with the currently proposed wording.

@saraadams
Copy link
Contributor Author

No worries, I didn't read it as a requirement, but we're happy to adjust.

@hicksjoseph hicksjoseph merged commit c7cf713 into bazelbuild:master Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants