Skip to content

Commit

Permalink
Undo breaking change of hiding android_common behind --experimental_g…
Browse files Browse the repository at this point in the history
…oogle_legacy_api

This should be patched into 0.28.0 to fix bazelbuild/intellij#976

Closes #8860.

PiperOrigin-RevId: 257574106
  • Loading branch information
jin authored and laurentlb committed Jul 16, 2019
1 parent 9d53cec commit 01bfc0c
Showing 1 changed file with 7 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,13 @@ public AndroidBootstrap(

@Override
public void addBindingsToBuilder(ImmutableMap.Builder<String, Object> builder) {
builder.put(
"android_common",
FlagGuardedValue.onlyWhenExperimentalFlagIsTrue(
FlagIdentifier.EXPERIMENTAL_GOOGLE_LEGACY_API, androidCommon));
// TODO: Make an incompatible change flag to hide android_common behind
// --experimental_google_legacy_api.
// Rationale: android_common module contains commonly used functions used outside of
// the Android Starlark migration. Let's not break them without an incompatible
// change process.
builder.put("android_common", androidCommon);

builder.put(
ApkInfoApi.NAME,
FlagGuardedValue.onlyWhenExperimentalFlagIsTrue(
Expand Down

0 comments on commit 01bfc0c

Please sign in to comment.