Skip to content

Commit

Permalink
Disable shadowed_action part of action_aspect_test
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 379606378
  • Loading branch information
twigg authored and copybara-github committed Jun 15, 2021
1 parent 4261b2a commit 04bed29
Showing 1 changed file with 16 additions and 15 deletions.
31 changes: 16 additions & 15 deletions src/test/shell/integration/action_aspect_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -306,21 +306,22 @@ EOF
diff "${package}/run_1_timestamp" "${package}/run_2_timestamp" \
|| fail "Starlark action should not rerun after bazel shutdown"

# Test that the Starlark action would rerun if the inputs of the
# shadowed action changed
rm "${package}/x.h"
echo "inline int x() { return 0; }" > "${package}/x.h"

bazel build "${package}:a" \
--aspects="//${package}:lib.bzl%actions_test_aspect" \
--output_groups=out || \
fail "bazel build should've succeeded"

cp "bazel-bin/${package}/run_timestamp" "${package}/run_3_timestamp"

diff "${package}/run_1_timestamp" "${package}/run_3_timestamp" \
&& fail "Starlark action should rerun after shadowed action inputs change" \
|| :
# TODO(b/191195108): Disabled due to flakiness. Should be its own test as well.
# # Test that the Starlark action would rerun if the inputs of the
# # shadowed action changed
# rm "${package}/x.h"
# echo "inline int x() { return 0; }" > "${package}/x.h"

# bazel build "${package}:a" \
# --aspects="//${package}:lib.bzl%actions_test_aspect" \
# --output_groups=out || \
# fail "bazel build should've succeeded"

# cp "bazel-bin/${package}/run_timestamp" "${package}/run_3_timestamp"

# diff "${package}/run_1_timestamp" "${package}/run_3_timestamp" \
# && fail "Starlark action should rerun after shadowed action inputs change" \
# || :
}

run_suite "Tests Starlark API pertaining to action inspection via aspect"

0 comments on commit 04bed29

Please sign in to comment.