Skip to content

Commit

Permalink
Move generate_workspace to src/tools
Browse files Browse the repository at this point in the history
Seems like a better location for it (easier for people to run than
src/main/java/com/google/devtools/build etc).

--
MOS_MIGRATED_REVID=102354250
  • Loading branch information
kchodorow authored and damienmg committed Sep 4, 2015
1 parent a708acd commit 0716303
Show file tree
Hide file tree
Showing 15 changed files with 39 additions and 39 deletions.
4 changes: 2 additions & 2 deletions site/docs/external.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ Bazel provides a tool to help generate these expansive `WORKSPACE` files, called
`generate_workspace`. Run the following to build the tool and see usage:

```
bazel run src/main/java/com/google/devtools/build/workspace:generate_workspace
bazel run //src/tools/generate_workspace
```

You can either specify directories containing Bazel projects (i.e., `WORKSPACE`
files) or Maven projects (i.e., `pom.xml` files). For example:

```bash
$ bazel run src/main/java/com/google/devtools/build/workspace:generate_workspace -- \
$ bazel run //src/tools/generate_workspace -- \
> --maven_project=/path/to/my/project \
> --bazel_project=/path/to/skunkworks \
> --bazel_project=/path/to/teleporter/project
Expand Down
2 changes: 1 addition & 1 deletion src/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ filegroup(
"//conditions:default": ["//src/main/native:libunix.so"],
}),
visibility = [
"//src/main/java/com/google/devtools/build/workspace:__pkg__",
"//src/test/java:__pkg__",
"//src/tools/generate_workspace:__pkg__",
],
)

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -419,8 +419,8 @@ java_library(
"//third_party:jquery",
],
visibility = [
"//src/main/java/com/google/devtools/build/workspace:__pkg__",
"//src/test/java:__subpackages__",
"//src/tools/generate_workspace/src/main/java/com/google/devtools/build/workspace:__pkg__",
],
runtime_deps = [
"//third_party:aether",
Expand Down
26 changes: 0 additions & 26 deletions src/main/java/com/google/devtools/build/workspace/BUILD

This file was deleted.

2 changes: 1 addition & 1 deletion src/test/shell/bazel/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ sh_test(
srcs = ["generate_workspace_test.sh"],
data = [
":test-deps",
"//src/main/java/com/google/devtools/build/workspace:generate_workspace",
"//src/tools/generate_workspace",
],
)

Expand Down
10 changes: 5 additions & 5 deletions src/test/shell/bazel/generate_workspace_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function tear_down() {
}

function generate_workspace() {
${bazel_data}/src/main/java/com/google/devtools/build/workspace/generate_workspace $@
${bazel_data}/src/tools/generate_workspace/generate_workspace $@
}

# Takes: groupId, artifactId, and version.
Expand Down Expand Up @@ -123,8 +123,8 @@ function test_pom() {
</project>
EOF

${bazel_data}/src/main/java/com/google/devtools/build/workspace/generate_workspace \
--maven_project=$TEST_TMPDIR &> $TEST_log || fail "generating workspace failed"
generate_workspace --maven_project=$TEST_TMPDIR &> $TEST_log \
|| fail "generating workspace failed"

cat $(cat $TEST_log | tail -n 2 | head -n 1) > ws
cat $(cat $TEST_log | tail -n 1) > build
Expand Down Expand Up @@ -169,8 +169,8 @@ function test_profile() {
</project>
EOF

${bazel_data}/src/main/java/com/google/devtools/build/workspace/generate_workspace \
--maven_project=$TEST_TMPDIR &> $TEST_log || fail "generating workspace failed"
generate_workspace --maven_project=$TEST_TMPDIR &> $TEST_log \
|| fail "generating workspace failed"
}

function test_submodules() {
Expand Down
8 changes: 8 additions & 0 deletions src/tools/generate_workspace/BUILD
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
java_binary(
name = "generate_workspace",
data = ["//src:libunix"],
jvm_flags = ["-Djava.library.path=$(GENDIR)/src/main/native"],
main_class = "com.google.devtools.build.workspace.GenerateWorkspace",
visibility = ["//visibility:public"],
runtime_deps = ["//src/tools/generate_workspace/src/main/java/com/google/devtools/build/workspace"],
)
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
java_library(
name = "workspace",
srcs = glob(["*.java"]),
visibility = ["//src/tools/generate_workspace:__pkg__"],
deps = [
"//src/main/java:analysis-exec-rules-skyframe",
"//src/main/java:bazel-core",
"//src/main/java:buildtool-runtime",
"//src/main/java:events",
"//src/main/java:options",
"//src/main/java:packages",
"//src/main/java:vfs",
"//src/tools/generate_workspace/src/main/java/com/google/devtools/build/workspace/maven",
"//src/tools/generate_workspace/src/main/java/com/google/devtools/build/workspace/maven:rule",
"//third_party:guava",
"//third_party:maven_model",
],
)
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ java_library(
"Resolver.java",
],
visibility = [
"//src/main/java/com/google/devtools/build/workspace:__pkg__",
"//src/test/java/com/google/devtools/build/workspace:__pkg__",
"//src/tools/generate_workspace/src/main/java/com/google/devtools/build/workspace:__pkg__",
"//src/tools/generate_workspace/src/test/java/com/google/devtools/build/workspace:__pkg__",
],
runtime_deps = [
"//third_party:maven_model",
Expand All @@ -28,7 +28,7 @@ java_library(
name = "rule",
srcs = ["Rule.java"],
visibility = [
"//src/main/java/com/google/devtools/build:__subpackages__",
"//src/tools/generate_workspace/src/main/java/com/google/devtools/build/workspace:__pkg__",
],
deps = [
"//src/main/java:events",
Expand Down

0 comments on commit 0716303

Please sign in to comment.