Add profiles to the call sites of updateRunfiles

To make it easier to debug #20748. Closes #20783. PiperOrigin-RevId: 596824058 Change-Id: I1dd6b940c30bd6c4b99904d19667f48a389b3a41
bazelbuild · Jan 9, 2024 · 18c8839 · 18c8839
1 parent 9d0468a
commit 18c8839
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/exec/local/LocalSpawnRunner.java b/src/main/java/com/google/devtools/build/lib/exec/local/LocalSpawnRunner.java
@@ -131,8 +131,10 @@ public SpawnResult exec(Spawn spawn, SpawnExecutionContext context)
     SpawnMetrics.Builder spawnMetrics = SpawnMetrics.Builder.forLocalExec();
     Stopwatch totalTimeStopwatch = Stopwatch.createStarted();
     Stopwatch setupTimeStopwatch = Stopwatch.createStarted();
-    runfilesTreeUpdater.updateRunfiles(
-        spawn.getRunfilesSupplier(), spawn.getEnvironment(), context.getFileOutErr());
+    try (var s = Profiler.instance().profile("updateRunfiles")) {
+      runfilesTreeUpdater.updateRunfiles(
+          spawn.getRunfilesSupplier(), spawn.getEnvironment(), context.getFileOutErr());
+    }
     if (Spawns.shouldPrefetchInputsForLocalExecution(spawn)) {
       context.prefetchInputsAndWait();
     }

diff --git a/src/main/java/com/google/devtools/build/lib/worker/WorkerSpawnRunner.java b/src/main/java/com/google/devtools/build/lib/worker/WorkerSpawnRunner.java
@@ -177,8 +177,10 @@ public SpawnResult exec(Spawn spawn, SpawnExecutionContext context)
                 String.format(
                     "%s worker %s", spawn.getMnemonic(), spawn.getResourceOwner().describe()))) {
 
-      runfilesTreeUpdater.updateRunfiles(
-          spawn.getRunfilesSupplier(), spawn.getEnvironment(), context.getFileOutErr());
+      try (var s = Profiler.instance().profile("updateRunfiles")) {
+        runfilesTreeUpdater.updateRunfiles(
+            spawn.getRunfilesSupplier(), spawn.getEnvironment(), context.getFileOutErr());
+      }
 
       InputMetadataProvider inputFileCache = context.getInputMetadataProvider();