-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
When
StateMachine
looks up a SkyKey
and is hooked up with a seque…
…ntial `StateMachine runAfter`. If looking up the `SkyKey` throws an exception, the next `StateMachine runAfter` will not be invoked. This is caused by mistakenly calling `tryHandleException(exception)` in `Lookup#ValueOrExceptionXLookup#doLookup()` method. In order to fix this bug, I did the following work in this change: * Rename relevant function names to `acceptValueInternal()` and `tryHandleExceptionInternal()`, and mark their visibility as `protected`. This will clearly indicate these two methods should not be reached outside `Lookup` class. * Correct to call `tryHandleExceptionInternal(skyKey, exception)` in `Lookup#ValueOrExceptionXLookup#doLookup()`. * Add more unit tests to cover calling `Lookup#ValueOrExceptionXLookup#doLookup()`. This method is only invoked when current `StateMachine` looks up **one** newly added `SkyKey`. `X` number of `Exception` types, can be 2 or 3. * Correct a wrong error message assertion in `ConstraintsTest#invalidSelectKeyError`. * Fix a minor bug in `TargetAndConfigurationProducer#RuleTransitionApplier#computeTransition()` State Machine method. Directly `return DONE` if getting `configConditions` fails. PiperOrigin-RevId: 571124557 Change-Id: I5fd9697808d7ff567bc866b5e5c61b662a66a31c
- Loading branch information
1 parent
d262c7d
commit 2390fae
Showing
3 changed files
with
278 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.