Verify that --coverage_report_generator points to an executable target.

Prevents an unsightly NPE later on. Fixes #6450 PiperOrigin-RevId: 490885958 Change-Id: I7444adb3cb816e98e03e4680a68eddd322170021
bazelbuild · Nov 25, 2022 · 3c1b115 · 3c1b115
1 parent cc712ee
commit 3c1b115
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/test/TestActionBuilder.java b/src/main/java/com/google/devtools/build/lib/analysis/test/TestActionBuilder.java
@@ -481,6 +481,9 @@ private TestParams createTestAction(int shards)
       TransitiveInfoCollection reportGeneratorTarget =
           ruleContext.getPrerequisite(":coverage_report_generator");
       reportGenerator = reportGeneratorTarget.getProvider(FilesToRunProvider.class);
+      if (reportGenerator.getExecutable() == null) {
+        ruleContext.ruleError("--coverage_report_generator does not refer to an executable target");
+      }
     }
 
     return new TestParams(

diff --git a/src/test/java/com/google/devtools/build/lib/analysis/test/TestActionBuilderTest.java b/src/test/java/com/google/devtools/build/lib/analysis/test/TestActionBuilderTest.java
@@ -370,4 +370,15 @@ private ImmutableList<Artifact.DerivedArtifact> getTestStatusArtifacts(String la
     return target.getProvider(TestProvider.class).getTestParams().getTestStatusArtifacts();
   }
 
+  @Test
+  public void testNonExecutableCoverageReportGenerator() throws Exception {
+    useConfiguration(
+        "--coverage_report_generator=//bad_gen:bad_cov_gen", "--collect_code_coverage");
+    checkError(
+        "bad_gen",
+        "some_test",
+        "--coverage_report_generator does not refer to an executable target",
+        "sh_library(name = 'bad_cov_gen')",
+        "cc_test(name = 'some_test')");
+  }
 }