Fix up old usages of the phrase "legacy globbing".

We switched to the phrase "non-Skyframe globbing" in 11d8ecf.

PiperOrigin-RevId: 432525572

src/main/java/com/google/devtools/build/lib/skyframe/PerBuildSyscallCache.java

@@ -31,9 +31,9 @@
 /**
  * A per-build cache of filesystem operations.
  *
- * <p>Allows non-Skyframe operations (like legacy globbing) to share a filesystem cache with
- * Skyframe nodes, and may be able to answer questions (like the type of a file) based on existing
- * data (like the directory listing of a parent) without filesystem access.
+ * <p>Allows non-Skyframe operations (like non-Skyframe globbing) to share a filesystem cache with
+ * Skyframe operations, and may be able to answer questions (like the type of a file) based on
+ * existing data (like the directory listing of a parent) without filesystem access.
  */
 public final class PerBuildSyscallCache implements SyscallCache {
   private final Supplier<LoadingCache<Pair<Path, Symlinks>, Object>> statCacheSupplier;

src/test/shell/bazel/bazelignore_test.sh

@@ -63,11 +63,11 @@ test_does_not_glob_into_ignored_directory() {
 
     # This weird line tests whether .bazelignore also stops the Skyframe-based
     # glob. Globbing (as of 2019 Oct) is done in a hybrid fashion: we do the
-    # legacy globbing because it's faster and Skyframe globbing because it's
-    # more incremental. In the first run, we get the results of the legacy
-    # globbing, but if we invalidate the BUILD file, the result of the legacy
-    # glob is invalidated and but the better incrementality allows the result of
-    # the Skyframe glob to be cached.
+    # non-Skyframe globbing because it's faster and Skyframe globbing because
+    # it's more incremental. In the first run, we get the results of the
+    # non-Skyframe globbing, but if we invalidate the BUILD file, the result of
+    # the non-Skyframe glob is invalidated and but the better incrementality
+    # allows the result of the Skyframe glob to be cached.
     echo "# change" >> BUILD
     bazel query //:all-targets > "$TEST_TMPDIR/targets"
     assert_not_contains "//:ignored/file" "$TEST_TMPDIR/targets"