Skip to content

Commit

Permalink
Update Truth to 0.44.
Browse files Browse the repository at this point in the history
This is necessary for some forthcoming changes that migrate to methods introduced in that version:
https://github.com/google/truth/releases/tag/release_0_44

While here, move diffutils from runtime_deps to deps. This is unlikely to matter in practice, but in principle it's the right thing, and it *might* matter if static analysis or other build tools (-Xlint:all?) went digging into the deps of Truth at compile time. Such problems (albeit when the dependency's API is publicly visible through the using library) are what prompted the creation of java_import#deps (internal Google bug 23781162). For other problems (that might also not apply here), see google/guava#2721
  • Loading branch information
cpovirk authored and katre committed Apr 25, 2019
1 parent 68a2744 commit 568048b
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions third_party/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -601,15 +601,15 @@ java_import(

java_import(
name = "truth",
jars = ["truth/truth-0.42.jar"],
runtime_deps = [
jars = ["truth/truth-0.44.jar"],
deps = [
":diffutils",
],
)

java_import(
name = "truth8",
jars = ["truth8/truth-java8-extension-0.42.jar"],
jars = ["truth8/truth-java8-extension-0.44.jar"],
)

java_import(
Expand Down
Binary file removed third_party/truth/truth-0.42.jar
Binary file not shown.
Binary file added third_party/truth/truth-0.44.jar
Binary file not shown.
Binary file not shown.

0 comments on commit 568048b

Please sign in to comment.